Added SCC TotalElement collection for metrics#2353
Merged
mergify[bot] merged 7 commits intodevelopfrom Apr 24, 2022
Merged
Conversation
optimisticben
commented
Mar 22, 2022
optimisticben
commented
Mar 22, 2022
🦋 Changeset detectedLatest commit: 02bd922 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
optimisticben
force-pushed
the
feat/l2geth-exporter-scc-collection
branch
from
8344b02 to
2f87f78
Compare
tynes
approved these changes
Apr 11, 2022
cfromknecht
reviewed
Apr 12, 2022
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
Looking good, apart from one nit I left another suggestion on how to deduplicate the getXXXTotalElements method though I wouldn't say it's blocking. We can merge or refactor later if you want
mslipper
approved these changes
Apr 24, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
* Added SCC TotalElement collection for metrics * Update addressTotalElementsCallStatus metric name Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Closes #2353 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
Closes #2353 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added SCC TotalElement collection for metrics
This is a draft because I think there's a simpler way.