fix(sdk): use correct overrides type#2468
Merged
mergify[bot] merged 2 commits intodevelopfrom Apr 15, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 050c589 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Replaces Overrides with CallOverrides for estimateGas functions so you can specify the "from" address.
smartcontracts
force-pushed
the
sc/sdk-call-overrides
branch
from
2e775d5 to
9cd363a
Compare
tynes
approved these changes
Apr 15, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
roninjin10
approved these changes
Apr 15, 2022
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Replaces Overrides with CallOverrides for estimateGas functions so you can specify the "from" address. Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Merged
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
Replaces Overrides with CallOverrides for estimateGas functions so you can specify the "from" address. Co-authored-by: Matthew Slipper <me@matthewslipper.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
… configuration (#2468) This PR completes the sequencer mode documentation in the vocs `docs/` directory as requested in the issue. The documentation now provides comprehensive coverage of how to configure and run `kona-node` in sequencer mode. ## Changes Made ### Documentation Content - **Overview**: Clear explanation of sequencer mode functionality and how it differs from validator mode - **Trait Abstractions**: Detailed coverage of key interfaces including: - `RollupNodeService` - main service trait defining operational modes - `AttributesBuilderConfig` - configures L2 block attribute construction - `SequencerActor` - core actor responsible for block production - **Programmatic Configuration**: Complete example showing how to use `RollupNodeBuilder` to configure sequencer mode - **CLI Usage**: Comprehensive reference of all sequencer-related flags and environment variables ### Key Features Documented - **Required Arguments**: All mandatory CLI flags needed to run in sequencer mode - **Sequencer-Specific Flags**: Complete reference table with defaults and descriptions: - `--sequencer.stopped` - Control sequencer startup state - `--sequencer.max-safe-lag` - Configure safe/unsafe head distance - `--sequencer.l1-confs` - Set L1 confirmation requirements - `--sequencer.recover` - Enable recovery mode - `--conductor.rpc` - Conductor service integration - **Configuration Examples**: Three practical examples covering basic, conductor-enabled, and recovery mode setups - **Operational Considerations**: Important callouts about L1 confirmations, recovery scenarios, and production deployment considerations ### Documentation Structure The documentation follows vocs conventions with: - Proper markdown formatting and code blocks - Info, tip, and caution callouts for important information - Comprehensive tables for flag references - Real-world configuration examples - Focus on practical usage while keeping content concise This addresses the issue requirements by providing complete documentation of trait abstractions, programmatic configuration via `kona-node` builder, CLI usage with all required arguments, and appropriate callouts throughout. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces Overrides with CallOverrides for estimateGas functions so you
can specify the "from" address.