proxyd: Reduce RPC request logging#2502
Merged
mergify[bot] merged 1 commit intodevelopfrom Apr 28, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 70fd180 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Logging the entire RPC request can be too "expensive" when logging request objects in a large JSON-RPC batch request. We log the raw HTTP request body instead so we can truncate effectively when the entire body exceeds the maxLogLength.
Inphi
force-pushed
the
inphi/verbose-causality
branch
from
26bff21 to
70fd180
Compare
mslipper
approved these changes
Apr 28, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging the entire RPC request can be too "expensive" when logging request
objects in a large JSON-RPC batch request. We log the raw HTTP request
body instead so we can truncate effectively when the entire body
exceeds the maxLogLength.