Merged
Conversation
l2geth: bring back unsupported RPC methods Previously, any RPC methods involving hot keys and signing by the node were disabled when the node ran with the OVM configured. This was to prevent users from attempting to use these methods against the live sequencer. Now that the infrastructure is more mature with `proxyd`, particular RPC requests can be routed appropriately and blocked at the infra level. Allowing these methods makes local development easier. This change cannot be adopted without coordination from infra providers, ensuring that they will block these methods at their infrastructure. Each optimism node has at least 1 key that is used to ensure block production is deterministic when running in clique mode. Also forward transactions to the sequencer when running as the verifier for the RPC endpoint `eth_sendTransaction`. This RPC utilizes a key that the node is managing.
Add verifier integration tests behind the env var `RUN_VERIFIER_TESTS`. Note that this depends on the batch submitter correctly submitting batches because the verifier syncs from the batches submitted by the batch submitter. The verifier is not enabled by default with the `docker-compose.yml` file. To enable it, the replicas field must be updated from `0` to `1`.
This commit fixes a bug in the batch submitter where not all timestamp information was being correctly rolled up. This has temporarily caused certain L1 syncing nodes to generate an incorrect state root. This PR will be followed by a second PR with an update to the DTL to guarantee that incorrect timestampd data can be corrected.
.env files were not being ignored by docker. This meant that any local environment variable changes you placed into an .env file would be pulled into docker images built inside of the ops package. Docker images should only be using environment variables as specified in their respective environment folders and should not copy over .env files.
Monotonicity violations were being reported in two locations, once in the sync service and then later in the worker. Because of recent updates in the sync service, there's never a case where monotonicity violations would not be caught first within the sync service. This code path only triggered within L1 syncing verifiers and caused issues with unintended timestamp manipulation.
This commit makes sure that the DTL correctly returns timestamps using the new scheme when the first batch submitter hardfork block is activated. If the block is not activated, the DTL will operate as it previously did.
This commit adds support for ERC20 deposits and withdrawals by introducing the concept of token bridge adapters. This gives the SDK a standard interface for interacting with token bridges even though the bridges may each have slightly different internal logic.
integration-tests: Increase withdrawal timeout
Alpine 3.14 has an issue (https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2) that prevents it from working on CircleCI at this time.
go/batch-submitter: Downgrade Alpine version
…patch-ctx fix(bss,dtl): correctly submit and parse timestamp information for L1 to L2 txs
test(integration): withdrawing a fake L2 token
feat(sdk): introduce token bridge adapters
removed unused variable removed-sequencer removed-sequencer references remove sequencer variable removed unused variable removed-sequencer removed-sequencer references remove sequencer variable
Depreciated unused variable from Integration tests
feat(sdk): implement finalize message
…ata-trasport-layer Removed constants from data-transport-layer
This was a known bug, but recently caught the reason in combing through the new copy in the specs repo. The old hack that auto defaulted to debug has been removed.
…ported-rpcs l2geth: bring back unsupported RPC methods
See #2093 for more details.
crtiical -> critical
fix: mimic BSS timestamp bug fix from #2093
integration-tests: Remove superfluous nightly env tests
feat(sdk): implement message wait time estimation
feat(sdk): start using sdk in integration tests
Bumps [simple-get](https://github.com/feross/simple-get) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/feross/simple-get/releases) - [Commits](feross/simple-get@v2.8.1...v2.8.2) --- updated-dependencies: - dependency-name: simple-get dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
feat: SDK beta release
maintenance: update ethers deps
l2geth: update readme
…rn/simple-get-2.8.2 build(deps): bump simple-get from 2.8.1 to 2.8.2
fix: have sdk use ethers peer dep
🦋 Changeset detectedLatest commit: b971743 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-op-batcher
fix(sdk): updated flaky test
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
- Coverage 75.37% 72.96% -2.42%
==========================================
Files 81 85 +4
Lines 2705 2918 +213
Branches 436 496 +60
==========================================
+ Hits 2039 2129 +90
- Misses 666 789 +123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mslipper
approved these changes
Feb 4, 2022
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Ref #2136 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.