Depreciated unused variable from Integration tests#2112
Conversation
|
There was a problem hiding this comment.
You'll also need to remove the reference to sequencerBalance shown below (on line 47)
There was a problem hiding this comment.
@smartcontracts i have removed it, please review and thanks for letting me know this
Codecov Report
@@ Coverage Diff @@
## develop #2112 +/- ##
===========================================
- Coverage 75.37% 73.37% -2.01%
===========================================
Files 81 85 +4
Lines 2705 2836 +131
Branches 436 464 +28
===========================================
+ Hits 2039 2081 +42
- Misses 666 755 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@smartcontracts i saw a proxy sequencer reference that was not removed and it was failing linting workflow but now i have removed that, can you trigger the workflow again please |
|
@smartcontracts looks like everything has passed ? Is there anything else ? |
|
@RishiKumarRay would you mind rebasing this PR into a single commit using the conventional commit format? Once that's done, I'll go ahead and approve (and then merge). |
|
@RishiKumarRay let me know if you're having any trouble rebasing, I can try to help |
|
@smartcontracts Yeah please help me , i have messed up rebasing the commit , can you guide me please? |
removed unused variable removed-sequencer removed-sequencer references remove sequencer variable removed unused variable removed-sequencer removed-sequencer references remove sequencer variable
RishiKumarRay
force-pushed
the
Remove-unused-variable
branch
from
c838205 to
1e27b34
Compare
|
@smartcontracts please check the rebase , i think i have successfully done it |
|
@smartcontracts Since i can see now only one commit is present so it is done right? |
Yep! Perfect. I will run the integration tests one more time... |
|
@smartcontracts Thanks , the tests has passed too |
|
Great work, thank you @RishiKumarRay! Feel free to email me at [kelvin AT optimism DOT io] for a hand-drawn contributor NFT :-) |
|
@smartcontracts thanks , this is cool , i really want something like that , also i have sended you mail from my personal id - rishirai 760 AT gmail dot com, you might have received it. thanks |
|
@smartcontracts did you received my email?? |
### Description Tracks peer ping latencies so we can return the latencies in the peer info response. Progress on #1562
3 participants
Description
remove the unused variable from the integration tests
Metadata