feat(sdk): start using sdk in integration tests#2122
Conversation
🦋 Changeset detectedLatest commit: edb2184 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
I removed this test because we should just handle this as part of 1.0. No need to have a dead test here for behavior we haven't specified.
There was a problem hiding this comment.
Instead of making this a second test, we can just assert this inside of the above test which does exactly the same L1 to L2 message. Slightly speeds up the integration tests, which will add up as we start consolidating more tests.
There was a problem hiding this comment.
Note to self: maybe worth having sendMessageToL1 and sendMessageToL2 functions to avoid needing the direction parameter
There was a problem hiding this comment.
I'm really happy with how simple this is
38addd6 to
7d4bd70
Compare
7d4bd70 to
31f0b4f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2122 +/- ##
===========================================
- Coverage 73.66% 72.66% -1.00%
===========================================
Files 67 84 +17
Lines 2187 2883 +696
Branches 327 481 +154
===========================================
+ Hits 1611 2095 +484
- Misses 576 788 +212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
31f0b4f to
a1662a1
Compare
a1662a1 to
edb2184
Compare
Description
First PR in a series of PRs to start integrating the SDK into the integration tests. It's too much work to do this all in one PR. Includes a few minor bugfixes to the SDK.