Skip to content

feat(sdk): introduce token bridge adapters#2105

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-bridge-adapters
Feb 1, 2022
Merged

feat(sdk): introduce token bridge adapters#2105
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-bridge-adapters

Conversation

@smartcontracts
Copy link
Contributor

Description
This commit adds support for ERC20 deposits and withdrawals by introducing the
concept of token bridge adapters. This gives the SDK a standard
interface for interacting with token bridges even though the bridges may
each have slightly different internal logic.

Metadata

  • Fixes ENG-1831
  • Fixes ENG-1830

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

⚠️ No Changeset found

Latest commit: 7582201

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts smartcontracts marked this pull request as draft January 31, 2022 19:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #2105 (7582201) into develop (f8d62ac) will decrease coverage by 2.00%.
The diff coverage is 49.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2105      +/-   ##
===========================================
- Coverage    75.37%   73.37%   -2.01%     
===========================================
  Files           81       85       +4     
  Lines         2705     2836     +131     
  Branches       436      464      +28     
===========================================
+ Hits          2039     2081      +42     
- Misses         666      755      +89     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 72.63% <49.24%> (-13.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/interfaces/types.ts 100.00% <ø> (ø)
packages/sdk/src/cross-chain-messenger.ts 54.28% <22.72%> (-11.85%) ⬇️
packages/sdk/src/cross-chain-provider.ts 78.71% <25.92%> (-8.97%) ⬇️
packages/sdk/src/adapters/dai-bridge.ts 35.71% <35.71%> (ø)
packages/sdk/src/adapters/eth-bridge.ts 52.50% <52.50%> (ø)
packages/sdk/src/adapters/standard-bridge.ts 55.55% <55.55%> (ø)
packages/sdk/src/adapters/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/interfaces/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/utils/contracts.ts 100.00% <100.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d62ac...7582201. Read the comment docs.

@smartcontracts smartcontracts marked this pull request as ready for review January 31, 2022 20:51
This commit adds support for ERC20 deposits and withdrawals by introducing the
concept of token bridge adapters. This gives the SDK a standard
interface for interacting with token bridges even though the bridges may
each have slightly different internal logic.
@smartcontracts smartcontracts merged commit 40ffd24 into develop Feb 1, 2022
@smartcontracts smartcontracts deleted the sc/sdk-bridge-adapters branch February 1, 2022 18:03
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

This PR adds required configuration to bootstrap devstack e2e tests for
the kona-node.

In particular it:

- Does small updates to the e2e justfile to help run node devstack tests
- Adds the devstack tests to CI
- Adds the required configuration to the network configuration files

Progress towards op-rs/kona#2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants