fix: have sdk use ethers peer dep#2134
Merged
smartcontracts merged 1 commit intodevelopfrom Feb 4, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 64e746b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
force-pushed
the
sc/sdk-peer-ethers
branch
from
8b8b573 to
64e746b
Compare
SmitV
approved these changes
Feb 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2134 +/- ##
========================================
Coverage 72.96% 72.96%
========================================
Files 85 85
Lines 2918 2918
Branches 496 496
========================================
Hits 2129 2129
Misses 789 789
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor bugfix, has SDK use ethers as a peer dependency instead of including as a direct dependency. This helps with certain ethers-specific typing issues.