fix(bss,dtl): correctly submit and parse timestamp information for L1 to L2 txs#2090
Merged
fix(bss,dtl): correctly submit and parse timestamp information for L1 to L2 txs#2090
Conversation
github-actions
bot
added
2-reviewers
A-op-batcher
Codecov Report
@@ Coverage Diff @@
## develop #2090 +/- ##
========================================
Coverage 75.37% 75.37%
========================================
Files 81 81
Lines 2705 2705
Branches 436 436
========================================
Hits 2039 2039
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
smartcontracts
force-pushed
the
feat/verifier-itests-patch-ctx
branch
from
1edf47b to
4cd0a1f
Compare
🦋 Changeset detectedLatest commit: b022c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This looks like its going to need a rebase |
tynes
reviewed
Jan 31, 2022
Add verifier integration tests behind the env var `RUN_VERIFIER_TESTS`. Note that this depends on the batch submitter correctly submitting batches because the verifier syncs from the batches submitted by the batch submitter. The verifier is not enabled by default with the `docker-compose.yml` file. To enable it, the replicas field must be updated from `0` to `1`.
This commit fixes a bug in the batch submitter where not all timestamp information was being correctly rolled up. This has temporarily caused certain L1 syncing nodes to generate an incorrect state root. This PR will be followed by a second PR with an update to the DTL to guarantee that incorrect timestampd data can be corrected.
.env files were not being ignored by docker. This meant that any local environment variable changes you placed into an .env file would be pulled into docker images built inside of the ops package. Docker images should only be using environment variables as specified in their respective environment folders and should not copy over .env files.
Monotonicity violations were being reported in two locations, once in the sync service and then later in the worker. Because of recent updates in the sync service, there's never a case where monotonicity violations would not be caught first within the sync service. This code path only triggered within L1 syncing verifiers and caused issues with unintended timestamp manipulation.
This commit makes sure that the DTL correctly returns timestamps using the new scheme when the first batch submitter hardfork block is activated. If the block is not activated, the DTL will operate as it previously did.
tynes
force-pushed
the
feat/verifier-itests-patch-ctx
branch
from
4cd0a1f to
1741d88
Compare
Contributor
|
I think this PR is good to merge, cc @smartcontracts @mslipper |
mslipper
approved these changes
Feb 1, 2022
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a series of fixes that makes sure the batch submitter is correctly submitting all transaction information required to sync from L1. It also includes a patch for the DTL that makes it able to sync from this slightly modified batch submission format. For sanity, we also include tests for running a verifier from L1 and checking that it correctly syncs as part of this PR.