Skip to content

l2geth: update readme#2120

Merged
mslipper merged 1 commit intodevelopfrom
fix/l2geth-readme
Feb 4, 2022
Merged

l2geth: update readme#2120
mslipper merged 1 commit intodevelopfrom
fix/l2geth-readme

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Feb 2, 2022

Description
Simply update the readme to make local development with l2geth easier

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

⚠️ No Changeset found

Latest commit: e56e0a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes force-pushed the fix/l2geth-readme branch from 8a2f7b2 to e56e0a5 Compare February 2, 2022 02:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #2120 (8a2f7b2) into develop (40ffd24) will increase coverage by 3.97%.
The diff coverage is n/a.

❗ Current head 8a2f7b2 differs from pull request most recent head e56e0a5. Consider uploading reports for the commit e56e0a5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2120      +/-   ##
===========================================
+ Coverage    73.37%   77.35%   +3.97%     
===========================================
  Files           85       57      -28     
  Lines         2836     1983     -853     
  Branches       464      292     -172     
===========================================
- Hits          2081     1534     -547     
+ Misses         755      449     -306     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer ?
message-relayer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/cross-chain-messenger.ts
packages/message-relayer/hardhat.config.ts
packages/sdk/hardhat.config.ts
packages/sdk/src/adapters/eth-bridge.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
packages/sdk/src/utils/misc-utils.ts
packages/sdk/src/adapters/dai-bridge.ts
packages/data-transport-layer/src/utils/common.ts
packages/data-transport-layer/src/utils/index.ts
...kages/data-transport-layer/src/utils/validation.ts
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ffd24...e56e0a5. Read the comment docs.

@mslipper mslipper merged commit a1f1477 into develop Feb 4, 2022
@mslipper mslipper deleted the fix/l2geth-readme branch February 4, 2022 17:25
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Small PR to remove the `IpNet` todo comments + `String` fields since
`IpNet` can be serialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants