Skip to content

fix: mimic BSS timestamp bug fix from #2093#2119

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-timestamp-fix
Feb 2, 2022
Merged

fix: mimic BSS timestamp bug fix from #2093#2119
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-timestamp-fix

Conversation

@cfromknecht
Copy link
Contributor

Description
See #2093 for more
details.

Metadata

  • Fixes ENG-1937

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: d093a6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/batch-submitter-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #2119 (d093a6b) into develop (f3989c0) will increase coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2119      +/-   ##
===========================================
+ Coverage    72.63%   73.50%   +0.87%     
===========================================
  Files           85       69      -16     
  Lines         2872     2314     -558     
  Branches       469      344     -125     
===========================================
- Hits          2086     1701     -385     
+ Misses         786      613     -173     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/hardhat.config.ts
packages/sdk/src/adapters/index.ts
packages/sdk/src/utils/index.ts
packages/sdk/src/index.ts
packages/sdk/src/adapters/dai-bridge.ts
packages/sdk/src/adapters/standard-bridge.ts
packages/sdk/src/utils/misc-utils.ts
packages/sdk/src/utils/merkle-utils.ts
packages/sdk/src/cross-chain-messenger.ts
packages/sdk/src/utils/coercion.ts
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3989c0...d093a6b. Read the comment docs.

@mslipper mslipper merged commit b9c037f into ethereum-optimism:develop Feb 2, 2022
@cfromknecht cfromknecht deleted the bss-timestamp-fix branch February 2, 2022 16:23
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

This PR fixes some of the outstanding todos in kona's codebase. In
particular:

- Promotes the dial period to CLI argument for p2p. Also does a small
refactor to the way the connection gater is configured
- Open an issue to phase out the `sync-req-resp` optimism protocol
#2141. Removed the todo to promote the configuration to CLI since the
node would not sync properly if the flag is not set, and this protocol
will eventually get phased out.

Progress towards #2119
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

Merges the `peer_info` and `peerstore` mappings into a single one.

Close #2119
theochap added a commit that referenced this pull request Jan 14, 2026
## Description

This PR fixes some of the outstanding todos in kona's codebase. In
particular:

- Promotes the dial period to CLI argument for p2p. Also does a small
refactor to the way the connection gater is configured
- Open an issue to phase out the `sync-req-resp` optimism protocol
#2141. Removed the todo to promote the configuration to CLI since the
node would not sync properly if the flag is not set, and this protocol
will eventually get phased out.

Progress towards #2119
theochap added a commit that referenced this pull request Jan 14, 2026
## Description

Merges the `peer_info` and `peerstore` mappings into a single one.

Close #2119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants