Skip to content

feat(sdk): implement finalize message#2113

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-finalize-message
Feb 1, 2022
Merged

feat(sdk): implement finalize message#2113
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-finalize-message

Conversation

@smartcontracts
Copy link
Contributor

Description
Implements the SDK's finalize message functionality.

Metadata

  • Fixes ENG-1827

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

⚠️ No Changeset found

Latest commit: 400175c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #2113 (400175c) into develop (40ffd24) will decrease coverage by 0.71%.
The diff coverage is 23.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2113      +/-   ##
===========================================
- Coverage    73.37%   72.66%   -0.72%     
===========================================
  Files           85       86       +1     
  Lines         2836     2875      +39     
  Branches       464      469       +5     
===========================================
+ Hits          2081     2089       +8     
- Misses         755      786      +31     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 68.99% <23.40%> (-3.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/adapters/standard-bridge.ts 55.55% <0.00%> (ø)
packages/sdk/src/interfaces/types.ts 100.00% <ø> (ø)
packages/sdk/src/cross-chain-provider.ts 75.11% <9.09%> (-3.60%) ⬇️
packages/sdk/src/cross-chain-messenger.ts 50.66% <25.00%> (-3.62%) ⬇️
packages/sdk/src/utils/merkle-utils.ts 27.27% <27.27%> (ø)
packages/sdk/src/utils/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ffd24...400175c. Read the comment docs.

Copy link

@SmitV SmitV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for when you fix the bug

@smartcontracts smartcontracts force-pushed the sc/sdk-finalize-message branch from a6f4d12 to 400175c Compare February 1, 2022 19:54
@smartcontracts smartcontracts merged commit b6074f5 into develop Feb 1, 2022
@smartcontracts smartcontracts deleted the sc/sdk-finalize-message branch February 1, 2022 21:19
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Adds an environment variable for the L2 chain ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants