Skip to content

Removed constants from data-transport-layer#2115

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
tonykogias:remove-unused-constants-in-data-trasport-layer
Feb 1, 2022
Merged

Removed constants from data-transport-layer#2115
smartcontracts merged 1 commit intoethereum-optimism:developfrom
tonykogias:remove-unused-constants-in-data-trasport-layer

Conversation

@tonykogias
Copy link
Contributor

@tonykogias tonykogias commented Feb 1, 2022

Description
Deleted constants.ts since no constant is being used anymore and updated associated files.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

⚠️ No Changeset found

Latest commit: 4708b50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #2115 (4708b50) into develop (b6074f5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2115      +/-   ##
===========================================
- Coverage    72.66%   72.63%   -0.03%     
===========================================
  Files           86       85       -1     
  Lines         2875     2872       -3     
  Branches       469      469              
===========================================
- Hits          2089     2086       -3     
  Misses         786      786
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <100.00%> (-0.91%) ⬇️
message-relayer 70.86% <ø> (ø)
sdk 68.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/data-transport-layer/src/utils/index.ts 100.00% <ø> (ø)
.../l1-ingestion/handlers/sequencer-batch-appended.ts 21.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6074f5...4708b50. Read the comment docs.

smartcontracts
smartcontracts approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@smartcontracts smartcontracts merged commit ceea12f into ethereum-optimism:develop Feb 1, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby @refcell
chore(node): Add rollup config env var (#2115)
2ae1bfb 
## Overview

Missed one in #2114; Adds an envvar for the rollup config.

Co-authored-by: refcell <abigger87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused constants in data-transport-layer

3 participants

@tonykogias @codecov-commenter @smartcontracts