l2geth: bring back unsupported RPC methods#2007
Conversation
🦋 Changeset detectedLatest commit: 0bc5365 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2007 +/- ##
========================================
Coverage 75.37% 75.37%
========================================
Files 81 81
Lines 2705 2705
Branches 436 436
========================================
Hits 2039 2039
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This is blocked being used in production until |
tynes
force-pushed
the
feat/bring-back-unsupported-rpcs
branch
from
46eb225 to
e23be8d
Compare
|
This has a merge conflict now that needs to be fixed |
l2geth: bring back unsupported RPC methods Previously, any RPC methods involving hot keys and signing by the node were disabled when the node ran with the OVM configured. This was to prevent users from attempting to use these methods against the live sequencer. Now that the infrastructure is more mature with `proxyd`, particular RPC requests can be routed appropriately and blocked at the infra level. Allowing these methods makes local development easier. This change cannot be adopted without coordination from infra providers, ensuring that they will block these methods at their infrastructure. Each optimism node has at least 1 key that is used to ensure block production is deterministic when running in clique mode. Also forward transactions to the sequencer when running as the verifier for the RPC endpoint `eth_sendTransaction`. This RPC utilizes a key that the node is managing.
tynes
force-pushed
the
feat/bring-back-unsupported-rpcs
branch
from
e23be8d to
81d9056
Compare
l2geth: bring back unsupported RPC methods
Previously, any RPC methods involving hot keys and
signing by the node were disabled when the node
ran with the OVM configured. This was to prevent
users from attempting to use these methods against
the live sequencer. Now that the infrastructure is
more mature with
proxyd, particular RPC requestscan be routed appropriately and blocked at the infra
level. Allowing these methods makes local development
easier.
This change cannot be adopted without coordination
from infra providers, ensuring that they will block
these methods at their infrastructure. Each optimism
node has at least 1 key that is used to ensure
block production is deterministic when running in
clique mode.
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata