Skip to content

fix(storage): avoid error in storage actions (hot-fix)#1400

Merged
joseivanlopez merged 1 commit intomasterfrom
fix-actions
Jun 27, 2024
Merged

fix(storage): avoid error in storage actions (hot-fix)#1400
joseivanlopez merged 1 commit intomasterfrom
fix-actions

Conversation

@joseivanlopez
Copy link
Copy Markdown
Contributor

@joseivanlopez joseivanlopez commented Jun 27, 2024 •
edited
Loading

Problem

Generating storage actions crashes, see:

Solution

Avoid actiongraph clean-up by the ruby GC.

Note: This is a hot-fix. A better solution is required.

@joseivanlopez joseivanlopez marked this pull request as ready for review June 27, 2024 08:38
@joseivanlopez joseivanlopez merged commit f5e867a into master Jun 27, 2024
@joseivanlopez joseivanlopez deleted the fix-actions branch June 27, 2024 08:45
@joseivanlopez joseivanlopez mentioned this pull request Jun 27, 2024
Closed
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
Merged
imobachgs added a commit that referenced this pull request Jun 27, 2024
@imobachgs
Update to release 9 (#1404)
8fe19db 
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
@joseivanlopez joseivanlopez mentioned this pull request Jun 28, 2024
Merged
joseivanlopez added a commit that referenced this pull request Jun 28, 2024
@joseivanlopez
feat(storage): avoid reference to compound actions (#1410)
5ca4494 
A hot-fix was implemeted by #1400
in order to avoid possible segmentation fault when generating the list
of storage actions.

This PR provides a better solution. It avoids references to
`CompoundAction` objects instead of keeping an unnecessary reference to
the source `Actiongraph` object.

See #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseivanlopez @imobachgs