Skip to content

fix(zypp): Fixed moving libzypp target to /mnt#1352

Merged
lslezak merged 1 commit intomasterfrom
fix_zypp_target
Jun 17, 2024
Merged

fix(zypp): Fixed moving libzypp target to /mnt#1352
lslezak merged 1 commit intomasterfrom
fix_zypp_target

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented Jun 17, 2024

Problem

  • Moving the libzypp target to /mnt (the target installed system) happened too early, already in the "propose" step, it needs to happen after partitioning the disk.
  • The side effect of this is that mounting the /mnt partition can shadow the libzypp cache so it could crash later. Also the next target used after the product change would be the /mnt instead of the /run/agama/zypp.

Solution

  • Move the target change to the "install" step

Notes

  • I found out that the Pkg.SourceCacheCopyTo call does not work properly with target different than /. It always copies the data from / ignoring the current target.
  • It could copy some wrong data from the Live ISO to the target, as a quick solution I have commented that out. I'll fix it later in a separate PR.

Testing

  • Tested manually
  • Updated unit tests

lslezak
lslezak commented Jun 17, 2024
View reviewed changes
lslezak
lslezak commented Jun 17, 2024
View reviewed changes
imobachgs
imobachgs approved these changes Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, either add an entry in the changes file now or when you finish the packaging fixes.

@lslezak
Copy link
Copy Markdown
Contributor Author

lslezak commented Jun 17, 2024

I'll add the changes in the next PR.

@lslezak lslezak merged commit a5caf80 into master Jun 17, 2024
@lslezak lslezak deleted the fix_zypp_target branch June 17, 2024 13:56
@imobachgs imobachgs added this to the Agama 9 milestone Jun 25, 2024
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
Merged
imobachgs added a commit that referenced this pull request Jun 27, 2024
@imobachgs
Update to release 9 (#1404)
8fe19db 
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Agama 9

Development

Successfully merging this pull request may close these issues.

2 participants

@lslezak @imobachgs