improve patterns selector

[jreidinger]

Problem

There is broken counter how in search box for pattern selector. Also there is no clear indication that nothing is matched.

Solution

See screenshots how it is improved:

Old:
counter:

empty result:

New:
counter:

empty result (attempt 1):

empty result (attempt 2):

[dgdavid]

I'would not use the <Label> component for this kind of things. Not even the Patternfly guys would use it either 😉

Not saying we have to follow strictly their design guidelines, but in this case I'm more aligned with them.

Use just plain old HTML like <span>, <b> or even <strong> if we considered it is something should be emphasise.

Also, do not hesitate of adding more text to make it clear. I cannot help too much with texts, but "No matches" looks a bit poor to me.

[dgdavid]

LGTM.

I just added to NP comments for the record, not asking for changing them now.

Thanks for taking care.

[dgdavid]

NP:

Sorry, I didn't realize before, but it is actually not needed to redefine the selector variable. You can just change {selector} to {selector.length ? selector : <NoResultFoundThing />} below. But don't worry and keep it as it is to minimize the conflicts with the new-ui branch.