fix: Emit signal when storage propeties change#1236
Merged
joseivanlopez merged 7 commits intoagama-project:masterfrom May 21, 2024
Merged
fix: Emit signal when storage propeties change#1236joseivanlopez merged 7 commits intoagama-project:masterfrom
joseivanlopez merged 7 commits intoagama-project:masterfrom
Conversation
joseivanlopez
force-pushed
the
storage-update-properties
branch
from
3aeb54c to
0761a25
Compare
imobachgs
reviewed
May 21, 2024
imobachgs
approved these changes
May 21, 2024
This was referenced May 21, 2024
joseivanlopez
added a commit
that referenced
this pull request
May 27, 2024
## Problem Changes in #1236 introduced a bug reading the product mount points. The list of mount points was read just after selecting a new product. At that time, the *storage* service has not updated its config yet, so it still uses the previous product. Note that the *manager* service calls to storage `#probe` when a new product is selected, and the *storage* service updates its config as part of the call to `#probe`. For that reason, the product mount points cannot be updated until probe is done. https://bugzilla.suse.com/show_bug.cgi?id=1225348 ## Solution Do not update the product mount points when the product changes. The list of product mount points is automatically refreshed once the probing is done.
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The value of the D-Bus properties ProductMountPoints and EncryptionMethods from the interface org.opensuse.Agama.Storage1.Proposal.Calculator depend on the selected product. Nevertheless, the PropertiesChanged signal is not emitted when the product changes. Therefore, proxies clients never update such values.
This implies that the option for FDE (Full Disk Encryption) might not be shown. See #1004 and #411.
Solution