Skip to content

fix(web): drop header link#1348

Merged
dgdavid merged 1 commit intomasterfrom
drop-header-link
Jun 17, 2024
Merged

fix(web): drop header link#1348
dgdavid merged 1 commit intomasterfrom
drop-header-link

Conversation

@dgdavid
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid commented Jun 17, 2024

Problem

While remaking the UI, an extra link to the overview page was added to the selected product name acting as page title. Although at some point we realized that it was not really useful, it was forgotten and got merged to the master branch letting us to confirm ours suspicions by gathering feedback about being kind of confusing (thanks @jreidinger!)

Solution

Drop such a link.

Testing

Tested manually

Notes

There are to worth mentioning notes related to this:

  • This is just an example of what we've said (at least internally) a bunch of times: the new UI layout still needing love at several levels (layout, code, testing, etc). It was just in a good enough shape for get merged into master and avoid diverging too much and, more important, stop maintaining two completely different UIs.
  • Maybe the product title should include the "installation" word apart of the product name. Something to think about.

It was no really needed and even confusing.
@dgdavid dgdavid requested review from imobachgs and jreidinger June 17, 2024 09:15
Copy link
Copy Markdown
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 75c103a into master Jun 17, 2024
@dgdavid dgdavid deleted the drop-header-link branch June 17, 2024 10:40
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants