Conversation
|
I wanted to review this and started by trying out I found it quite confusing how it shows |
|
I would open a new issue to improve the
Perhaps @mchf have some additional ideas. Having said that, I think this PR is unrelated to those issues. |
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Sorry, I don't see how this helps. 🥲
Well, the prompt ends up being colored, that is nice,
and there is a help text but I argue that the feature which is describes is superfluous.
rust/agama-cli/src/auth.rs
Outdated
| Password::new("Please, introduce the root password:") | ||
| .with_validator(validator) | ||
| .without_confirmation() | ||
| .with_help_message("Press <esc> to exit.") |
There was a problem hiding this comment.
I don't see the purpose of this. It helps the user to distinguish entering an empty password from not entering a password?
There was a problem hiding this comment.
Sorry, I do not get the question
There was a problem hiding this comment.
The main point is to switch from rpassword to inquire, which is a more general library for handling user interaction (rpassword is only for passwords).
There was a problem hiding this comment.
I am nitpicking on the existence of this help message. When I remove the help, I can still cancel the operation (and get a CliError::InteractivePassword).
I, as a user, am used to canceling password input by simply entering a garbage or empty password. (Unless the counterparty is a Bank that penalizes all incorrect attempts by $100 and a 3 hour delay until the next attempt, this is a work of fiction 🤣 )
For my personal UX, it is better to hide the help message, because it just draws my attention away towards a useless feature.
Co-authored-by: Martin Vidner <mvidner@suse.cz>
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Thanks! I still have comments but the PR is good enough for merging
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
3 participants
Inquire is a library for building interactive prompts. It offers many "widgets" (check the demo!) and it looks like a better solution for our use case.
This PR replaces rpassword with Inquire.