fix(Live): Fixed console messages displayed twice#1359

Merged

lslezak merged 1 commit intomasterfrom

fix_console_messages

Jun 19, 2024

Contributor

lslezak commented Jun 19, 2024

Problem

The console messages are often displayed twice
The SSL certificate is generated asynchronously, the login service might be started before the certificate fingerprint message is generated.
After that the fingerprint message is created then the updated messages are displayed again, resulting in two similar messages which might be confusing

Solution

Added a helper service which postpones the login service until the certificate fingerprint is generated
However, we cannot wait forever. If the webserver gets stucked or crashes before saving the certificate to disk then you would not be able to login
So there is a 15 seconds timeout, after that the messages are displayed even if still not complete
But in most cases the delay is just 2 seconds

Testing

Tested manually

Screenshots


          fix(Live): Fixed console messages displayed twice

98475b0

imobachgs approved these changes

View reviewed changes

lslezak merged commit 1b49896 into master

lslezak deleted the fix_console_messages branch

June 19, 2024 14:09

imobachgs added this to the Agama 9 milestone

imobachgs mentioned this pull request

Update to release 9 #1404

Merged

imobachgs added a commit that referenced this pull request


          Update to release 9 (#1404)

8fe19db

Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet