inject complete lshw and adapt example to work with whole lshw#1242
inject complete lshw and adapt example to work with whole lshw#1242jreidinger merged 7 commits intomasterfrom
Conversation
autoinstallation/README.md
Outdated
| local sizedDisks = std.filter(function(d) std.objectHas(d, 'size'), disks); | ||
| local sorted = std.sort(sizedDisks, function(x) x.size); | ||
| sorted[0].logicalname; | ||
| local selectClass(lshw, class) = |
There was a problem hiding this comment.
IMHO, we should offer this as some kind of helper. I would not expect the users to have to include this on their own profiles.
There was a problem hiding this comment.
yeap, that is open question. Basically I think we should provide something like jsonnet library that is also injected into jsonnet during evaluation. At least two helpers will be useful..selectClass for class filtering and findID to find one specific id ( useful to e.g. check physical memory ).
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
I like the solution but I think we need better names for those helpers as they are part of the public API.
rust/share/agama.libsonnet
Outdated
| result, | ||
|
|
||
| // function go throught lshw output and returns object with given "id" or null if not found. | ||
| findID(lshw, id):: |
There was a problem hiding this comment.
About the name of the function, you are not "finding" and ID, but an object. So I would rename it to findById or something similar (or findObject or whatever).
There was a problem hiding this comment.
Please, document the arguments (type and so on).
rust/share/agama.libsonnet
Outdated
| @@ -0,0 +1,26 @@ | |||
| // function go throught lshw output and enlist only given class. | |||
| // Basically it is same as calling `lshw -class <class>`. | |||
| selectClass(lshw, class):: | |||
There was a problem hiding this comment.
selectClass looks good enough. But perhaps to be consistent with my suggestion below we could use findClass or something similar.
There was a problem hiding this comment.
Please, document the arguments.
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Please, update the changes file.
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
2 participants
Problem
There is only limited subset of hardware information for jsonnet.
Solution
Add complete json tree from lshw and adapt example how to search for the biggest disk. Also add utils library for easier search in lshw output and enhance example.
Testing