fix(web): do not render App on protected routes#1366
Merged
Conversation
imobachgs
force-pushed
the
fix-protected-routes
branch
2 times, most recently
from
db7fe8f to
aa8b5dd
Compare
imobachgs
force-pushed
the
fix-protected-routes
branch
from
aa8b5dd to
94fa7ba
Compare
jreidinger
reviewed
Jun 21, 2024
| export default function Protected() { | ||
| const { isLoggedIn } = useAuth(); | ||
|
|
||
| if (isLoggedIn === undefined) return; |
Contributor
There was a problem hiding this comment.
I think this deserve a bit of comment in code why we do it as it is not obvious especialyl with combination of condition below.
Contributor
Author
There was a problem hiding this comment.
Well, it is a rather typical pattern in React/JavaScript, but a comment won't hurt.
imobachgs
force-pushed
the
fix-protected-routes
branch
from
eceff90 to
1a9f374
Compare
jreidinger
approved these changes
Jun 21, 2024
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When visiting the root route (
/), the App component is rendered even if the user is not logged in. Of course, this causes many errors that are not visible in the UI but in the network monitor.Fixing this problem requires moving the code to handle phase and status changes to a higher place in the hierarchy because, now,
Appis rendered "too late" to observe status changes.Failed connection attempts