Skip to content

service: Avoid reading product mount points too early#1264

Merged
joseivanlopez merged 2 commits intoagama-project:masterfrom
joseivanlopez:bsc#1225348
May 27, 2024
Merged

service: Avoid reading product mount points too early#1264
joseivanlopez merged 2 commits intoagama-project:masterfrom
joseivanlopez:bsc#1225348

Conversation

@joseivanlopez
Copy link
Copy Markdown
Contributor

@joseivanlopez joseivanlopez commented May 27, 2024

Problem

Changes in #1236 introduced a bug reading the product mount points.

The list of mount points was read just after selecting a new product. At that time, the storage service has not updated its config yet, so it still uses the previous product.

Note that the manager service calls to storage #probe when a new product is selected, and the storage service updates its config as part of the call to #probe. For that reason, the product mount points cannot be updated until probe is done.

https://bugzilla.suse.com/show_bug.cgi?id=1225348

Solution

Do not update the product mount points when the product changes. The list of product mount points is automatically refreshed once the probing is done.

@coveralls
Copy link
Copy Markdown

coveralls commented May 27, 2024

Coverage Status

coverage: 70.363% (+0.001%) from 70.362%
when pulling 79c53c1 on joseivanlopez:bsc#1225348
into 208d111 on openSUSE:master.

@joseivanlopez joseivanlopez marked this pull request as ready for review May 27, 2024 12:46
@joseivanlopez joseivanlopez merged commit 9267f32 into agama-project:master May 27, 2024
@kobliha
Copy link
Copy Markdown
Contributor

kobliha commented May 28, 2024

Your change has done the job. Now only / or /var can be used for Micro OS. Thx!

@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants