fix: set installer language and keyboard layout#1375
Merged
Conversation
dgdavid
approved these changes
Jun 25, 2024
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
UI wise LGTM having in mind there will be another round of improvements when time permits.
Contributor
Author
|
Ruby tests are fixed in #1376. |
mvidner
reviewed
Jun 26, 2024
| def self.included(base) | ||
| base.class_eval do | ||
| dbus_interface LOCALE_INTERFACE do | ||
| dbus_method :SetLocale, "in locale:s" do |locale| |
Contributor
There was a problem hiding this comment.
Names of locales differ, notably between Linux and browsers: en_US.UTF-8 vs en-us so we should specify what the API expects or we will get subtle bugs
Contributor
Author
There was a problem hiding this comment.
In this case, it expects an en_US.UTF-8 kind of locale. That's the only locale that the backend understands. The transformation is performed in the installerL10n.jsx context.
I have added a comment to clarify that. Thanks!
| import InstallationFinished from "./InstallationFinished"; | ||
|
|
||
| jest.mock("~/client"); | ||
| jest.mock("~/components/core/InstallerOptions", () => () => <div>Instlaler Options</div>); |
This was referenced Jun 26, 2024
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The installer language/keymap selection does not work properly. Although most of the problems have existed for quite some time, the new UI makes them more evident.
Solution
SetLocalemethod, so we know exactly when it is finished.Testing
Known problems