fix(qqbot): add missing is_reconnect parameter to QQAdapter.connect() - #52922
fix(qqbot): add missing is_reconnect parameter to QQAdapter.connect()#52922iborazzi wants to merge 1 commit into
Conversation
d056391 to
f203169
Compare
|
Thanks for submitting this fix! The core change ( However, this diff has encoding corruption that would block merge:
These appear to be editor encoding issues. PR #52966 has the same functional fix without any encoding problems and includes a test. If you'd like to salvage this PR, the file needs to be re-edited with proper UTF-8 handling. Just flagging this for maintainers! |
f203169 to
1f2d82b
Compare
|
Re-saved adapter.py with BOM-free UTF-8 encoding — the diff was previously corrupted due to a PowerShell encoding issue. Force-pushed; diff should now be clean. Sorry for the delay — just saw the encoding feedback today and pushed the fix right away. |
|
Closing — net-negative in current form. The 63/63 churn is almost entirely UTF-8 mojibake: every The underlying fix is welcome — please resubmit just the |
Problem
Commit 43b8ba4 added an
is_reconnect: bool = Falsekeyword argumentto
BasePlatformAdapter.connect()and updatedgateway/run.pyto passis_reconnect=Trueon reconnect attempts. However,QQAdapter.connect()was not updated to accept this parameter, causing a
TypeErroron everyreconnect and triggering an infinite retry loop.
Fix
Add the
is_reconnect: bool = Falsekeyword-only parameter toQQAdapter.connect()ingateway/platforms/qqbot/adapter.py(line 281)to match the base class signature.
Changes
gateway/platforms/qqbot/adapter.py: updatedconnect(self)→connect(self, *, is_reconnect: bool = False)Testing
Verified no other platform adapters were missing this parameter.
Fixes #52914