Skip to content

fix(qqbot): accept is_reconnect kwarg in connect() to match base class signature - #59436

Closed
scutken wants to merge 1 commit into
NousResearch:mainfrom
scutken:fix/qqbot-connect-is-reconnect-signature
Closed

scutken wants to merge 1 commit into
NousResearch:mainfrom
scutken:fix/qqbot-connect-is-reconnect-signature

Conversation

@scutken

@scutken scutken commented Jul 6, 2026

Copy link
Copy Markdown

Problem

QQ bot fails to reconnect after gateway restart with error:

QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'

All other platform adapters accept the is_reconnect parameter (from BasePlatformAdapter.connect), but QQ adapter was missed when this parameter was added to the base class.

Fix

Add *, is_reconnect: bool = False to QQAdapter.connect() signature to match the base class contract.

Verification

  • Gateway restart: QQ bot reconnects successfully (state goes from retrying to connected)
  • All other platforms already have this parameter — no regression risk

@scutken

scutken commented Jul 6, 2026

Copy link
Copy Markdown
Author

Closes #52914

@scutken

scutken commented Jul 6, 2026

Copy link
Copy Markdown
Author

Closing in favor of earlier PR #54037 which has the same fix.

@scutken scutken closed this Jul 6, 2026
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists labels Jul 6, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Duplicate of #52966 (earliest still-open canonical fix for #52914) — byte-identical one-line is_reconnect signature fix to QQAdapter.connect(). Note the earlier anchor #52922 is now closed/unmerged, so #52966 is the canonical open PR; this fix is also present in #53546/#54029/#54547/#57105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants