Skip to content

fix(qqbot): add missing is_reconnect parameter to connect() - #55788

Closed
x15jin wants to merge 1 commit into
NousResearch:mainfrom
x15jin:fix/qqbot-is-reconnect
Closed

fix(qqbot): add missing is_reconnect parameter to connect()#55788
x15jin wants to merge 1 commit into
NousResearch:mainfrom
x15jin:fix/qqbot-is-reconnect

Conversation

@x15jin

@x15jin x15jin commented Jun 30, 2026

Copy link
Copy Markdown

Description

The QQ Bot adapter's connect() method was missing the is_reconnect
keyword argument that the gateway passes during reconnection. All
other platform adapters (Telegram, Discord, Slack, Feishu, etc.)
accept this parameter.

Without it, the QQ bot disconnects once and can never reconnect,
causing permanent disconnection until the gateway is restarted.

Bug

QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'

Fix

Added *, is_reconnect: bool = False to the connect method signature,
matching the pattern used by all other platform adapters.

The QQ Bot adapter's connect() method was missing the is_reconnect
keyword argument that the gateway passes during reconnection. All
other platform adapters (Telegram, Discord, Slack, Feishu, etc.)
accept this parameter.

Without it, the QQ bot disconnects once and can never reconnect,
causing permanent disconnection until the gateway is restarted.

Bug: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/qqbot QQ Bot adapter P2 Medium — degraded but workaround exists sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists labels Jun 30, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #52966 — byte-identical one-line connect(self, *, is_reconnect: bool = False) signature fix for the QQBot reconnect regression (issue #52914). Note: the earlier-cited canonical PR #52922 is now closed/unmerged and the fix is not on main, so #52966 is the earliest still-open canonical in this saturated cluster (also: #53546, #53948, #54037, #54165, #54547, #54977). A maintainer should pick one to merge.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused QQBot reconnect fix. This is now redundant because the same behavior is implemented on current main.

  • Automated hermes-sweeper review verified QQAdapter.connect(self, *, is_reconnect: bool = False) at gateway/platforms/qqbot/adapter.py:281.
  • The reconnect path forwards this keyword at gateway/run.py:3463-3466 and invokes it with True at gateway/run.py:7910-7912.
  • Commit 276542c729c10ff9d093760897f4c2d1256a79ce added the implementation and QQ-specific regression coverage at tests/gateway/test_qqbot.py:193-206.
  • The existing discussion correctly identified the duplicate cluster; main has since received the fix and broader contract coverage.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/qqbot QQ Bot adapter sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants