fix(qqbot): add missing is_reconnect parameter to connect() - #55788
Closed
x15jin wants to merge 1 commit into
Closed
fix(qqbot): add missing is_reconnect parameter to connect()#55788x15jin wants to merge 1 commit into
x15jin wants to merge 1 commit into
Conversation
The QQ Bot adapter's connect() method was missing the is_reconnect keyword argument that the gateway passes during reconnection. All other platform adapters (Telegram, Discord, Slack, Feishu, etc.) accept this parameter. Without it, the QQ bot disconnects once and can never reconnect, causing permanent disconnection until the gateway is restarted. Bug: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'
Collaborator
Duplicate of #52966 — byte-identical one-line |
1 task
Contributor
|
Thanks for the focused QQBot reconnect fix. This is now redundant because the same behavior is implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The QQ Bot adapter's
connect()method was missing theis_reconnectkeyword argument that the gateway passes during reconnection. All
other platform adapters (Telegram, Discord, Slack, Feishu, etc.)
accept this parameter.
Without it, the QQ bot disconnects once and can never reconnect,
causing permanent disconnection until the gateway is restarted.
Bug
Fix
Added
*, is_reconnect: bool = Falseto the connect method signature,matching the pattern used by all other platform adapters.