fix(qqbot): accept gateway reconnect flag - #61356
Closed
yangguo wants to merge 1 commit into
Closed
Conversation
Collaborator
Duplicate of #52966 -- identical one-line signature fix ( |
Author
|
Closing as a duplicate of #59353, which has the same minimal QQBot reconnect-kwarg fix with a clearer dedicated regression test. I added live reproduction details and local validation results there: #59353 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_reconnect=Truein the existing redirect-guard test.Why
GatewayRunner._connect_adapter_with_timeout()now forwardsis_reconnectto all platform adapters so reconnects can preserve server-side queues. QQBot overrodeconnect()with the old no-kwarg signature, causing configured QQBot gateways to fail withQQAdapter.connect() got an unexpected keyword argument is_reconnecton startup/reconnect.Tests
scripts/run_tests.sh tests/gateway/test_qqbot.py -qscripts/run_tests.sh tests/gateway/test_platform_reconnect.py tests/gateway/relay/test_relay_adapter.py -q.venv/bin/python -m ruff check gateway/platforms/qqbot/adapter.py tests/gateway/test_qqbot.py