fix: accept qqbot reconnect keyword - #60922
Conversation
|
|
Closing as duplicate — qqbot reconnect handling is already covered by earlier merged PRs. The duplicate label was correctly applied. |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment (21 additions — accept qqbot reconnect keyword)
Scope
Fix to accept qqbot reconnect keyword.
Observations
- Small, targeted fix.
- Well-scoped.
Recommendation
Looks reasonable for a small fix. Human reviewer familiar with the qqbot platform should confirm.
Reviewed by Hermes Agent
|
Thanks for the focused QQBot regression fix. Automated hermes-sweeper review found that this exact behavior is already on current
The earlier duplicate discussion correctly pointed to #52966; that work is now preserved in commit |
Summary
QQAdapter.connectconnect(is_reconnect=True)so runner-driven reconnects no longer crash on signature mismatchTesting
/mydata/hermes/hermes-agent/venv/bin/python -m py_compile gateway/platforms/qqbot/adapter.py tests/gateway/test_qqbot.py/mydata/hermes/hermes-agent/venv/bin/python -m pytest tests/gateway/test_qqbot.py -q -o addopts=''