fix(qqbot): add missing is_reconnect param to QQAdapter.connect() - #58607
Closed
Makat0 wants to merge 1 commit into
Closed
fix(qqbot): add missing is_reconnect param to QQAdapter.connect()#58607Makat0 wants to merge 1 commit into
Makat0 wants to merge 1 commit into
Conversation
The gateway's reconnection loop passes `is_reconnect=True` to `adapter.connect()`, but `QQAdapter.connect()` did not accept keyword arguments — causing a TypeError on every reconnect attempt and preventing the QQ bot from recovering after a dropped WebSocket. Add the `is_reconnect` keyword-only parameter with a default of `False` to match the `BasePlatformAdapter.connect()` signature that all other platform adapters already implement. Co-Authored-By: Claude <noreply@anthropic.com>
alt-glitch
added
type/bug
Collaborator
Duplicate of #52966 — identical one-line fix adding the keyword-only |
Author
|
Duplicate of 86a0c55 — the GROUP_MESSAGE_CREATE smart trigger support is already part of that commit. This 1-line fix is superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QQAdapter.connect()was missing theis_reconnectkeyword-only parameter thatgateway/run.pypasses on reconnection attemptsTypeErroron every reconnect, preventing the QQ bot from recovering after a dropped WebSocketBasePlatformAdapter.connect()interfaceTest plan
🤖 Generated with Claude Code