Skip to content

fix(qqbot): add missing is_reconnect parameter to connect() - #59636

Closed
mosike99 wants to merge 1 commit into
NousResearch:mainfrom
mosike99:fix/qqbot-is-reconnect
Closed

fix(qqbot): add missing is_reconnect parameter to connect()#59636
mosike99 wants to merge 1 commit into
NousResearch:mainfrom
mosike99:fix/qqbot-is-reconnect

Conversation

@mosike99

@mosike99 mosike99 commented Jul 6, 2026

Copy link
Copy Markdown

BasePlatformAdapter.connect() declares async def connect(self, *, is_reconnect: bool = False) -> bool (base.py:2864), but QQAdapter.connect() only has async def connect(self) -> bool, missing the is_reconnect keyword.

When the gateway attempts to reconnect the QQ bot platform, it calls adapter.connect(is_reconnect=True), causing a TypeError because QQAdapter doesn't accept the parameter. This makes reconnection impossible without a gateway restart.

Fix: add the *, is_reconnect: bool = False parameter to QQAdapter.connect(), matching the base class signature.

@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jul 6, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #53948 — byte-identical one-line fix adding the keyword-only is_reconnect: bool = False parameter to QQAdapter.connect(). Note: the earlier cluster anchor #52922 is now CLOSED (unmerged) and the fix is still absent on main, so #53948 is the earliest OPEN canonical fix for this contract gap (other open siblings: #54037, #54165, #54547).

@liuhao1024

Copy link
Copy Markdown
Contributor

Closing as a duplicate of #53948 — byte-identical fix for the same root cause (QQAdapter.connect() missing is_reconnect parameter). The earlier PR (#53948 by fantaskiss) is canonical.

@mosike99 mosike99 closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants