fix(qqbot): add missing is_reconnect parameter to QQAdapter.connect() - #60161
Closed
chenw0164-beep wants to merge 1 commit into
Closed
fix(qqbot): add missing is_reconnect parameter to QQAdapter.connect()#60161chenw0164-beep wants to merge 1 commit into
chenw0164-beep wants to merge 1 commit into
Conversation
The gateway passes is_reconnect=True when reconnecting adapters, but QQAdapter.connect() was missing this parameter, causing: ✗ qqbot error: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect' Added *, is_reconnect: bool = False to match the canonical adapter signature expected by gateway/run.py.
Collaborator
Duplicate of #52966 — byte-identical one-line fix ( |
Contributor
|
Thanks for the focused QQBot reconnect fix. This is already implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gateway passes
is_reconnect=Truewhen reconnecting platform adapters, butQQAdapter.connect()was missing this parameter in its signature.Error
Fix
Added
*, is_reconnect: bool = FalsetoQQAdapter.connect()to match the canonical adapter signature expected bygateway/run.py.Testing
✓ qqbot connected+Ready, session_id=...