Skip to content

fix(qqbot): add is_reconnect param to connect() to match base contract - #59575

Closed
mapleafgo wants to merge 1 commit into
NousResearch:mainfrom
mapleafgo:fix/qqbot-connect-is_reconnect
Closed

fix(qqbot): add is_reconnect param to connect() to match base contract#59575
mapleafgo wants to merge 1 commit into
NousResearch:mainfrom
mapleafgo:fix/qqbot-connect-is_reconnect

Conversation

@mapleafgo

Copy link
Copy Markdown

QQAdapter.connect() was missing the *, is_reconnect: bool = False keyword argument required by BasePlatformAdapter. The gateway's reconnect watcher calls connect(is_reconnect=True) when re-establishing a failed platform connection, causing::

TypeError: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'

This meant every automatic reconnection attempt (default every 300s) immediately failed with the same TypeError, making the QQ Bot platform permanently stuck in a reconnection loop without ever successfully reconnecting.

QQAdapter.connect() was missing the *, is_reconnect: bool = False keyword argument required by BasePlatformAdapter. The gateway's reconnect watcher calls connect(is_reconnect=True) when re-establishing a failed platform connection, causing::

    TypeError: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'

This meant every automatic reconnection attempt (default every 300s) immediately failed with the same TypeError, making the QQ Bot platform permanently stuck in a reconnection loop without ever successfully reconnecting.
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/qqbot QQ Bot adapter P2 Medium — degraded but workaround exists sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists labels Jul 6, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #52966 (the earliest still-open fix in the saturated QQBot is_reconnect cluster). This PR is the byte-identical one-line signature fix async def connect(self, *, is_reconnect: bool = False) addressing the same v0.17.0 regression (issue #52914). Note the prior cluster anchor #52922 is closed/unmerged, so #52966 is canonical.

@mapleafgo

Copy link
Copy Markdown
Author

Duplicate of #52966 — same one-line fix, theirs is 10 days earlier. Closing in favor of #52966.

@mapleafgo mapleafgo closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants