fix(qqbot): add is_reconnect param to connect() to match base contract - #59575
Closed
mapleafgo wants to merge 1 commit into
Closed
fix(qqbot): add is_reconnect param to connect() to match base contract#59575mapleafgo wants to merge 1 commit into
mapleafgo wants to merge 1 commit into
Conversation
QQAdapter.connect() was missing the *, is_reconnect: bool = False keyword argument required by BasePlatformAdapter. The gateway's reconnect watcher calls connect(is_reconnect=True) when re-establishing a failed platform connection, causing::
TypeError: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'
This meant every automatic reconnection attempt (default every 300s) immediately failed with the same TypeError, making the QQ Bot platform permanently stuck in a reconnection loop without ever successfully reconnecting.
Collaborator
Duplicate of #52966 (the earliest still-open fix in the saturated QQBot |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QQAdapter.connect() was missing the *, is_reconnect: bool = False keyword argument required by BasePlatformAdapter. The gateway's reconnect watcher calls connect(is_reconnect=True) when re-establishing a failed platform connection, causing::
This meant every automatic reconnection attempt (default every 300s) immediately failed with the same TypeError, making the QQ Bot platform permanently stuck in a reconnection loop without ever successfully reconnecting.