fix(qqbot): add is_reconnect parameter to QQAdapter.connect() - #60739
Closed
litaonet wants to merge 1 commit into
Closed
fix(qqbot): add is_reconnect parameter to QQAdapter.connect()#60739litaonet wants to merge 1 commit into
litaonet wants to merge 1 commit into
Conversation
Align QQAdapter.connect() signature with BasePlatformAdapter.connect(), which accepts an is_reconnect keyword argument. Without this parameter, the gateway raises 'got an unexpected keyword argument is_reconnect' when reconnecting the QQBot WebSocket.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align
QQAdapter.connect()signature withBasePlatformAdapter.connect(), which accepts anis_reconnectkeyword argument (defined ingateway/platforms/base.pyline 2864).Problem
When the gateway attempts to reconnect the QQBot WebSocket, it calls
adapter.connect(is_reconnect=True). The QQAdapter'sconnect()method did not accept this parameter, causing:This prevents the QQBot platform from reconnecting after transient network drops.
Fix
Add
*, is_reconnect: bool = FalsetoQQAdapter.connect()ingateway/platforms/qqbot/adapter.py, matching the base class signature.Verification
is_reconnectin theirconnect()methods.