Skip to content

fix(qqbot): accept is_reconnect kwarg in connect() to match base adapter interface - #57537

Closed
iborazzi wants to merge 1 commit into
NousResearch:mainfrom
iborazzi:fix/qqbot-connect-is-reconnect-param
Closed

fix(qqbot): accept is_reconnect kwarg in connect() to match base adapter interface#57537
iborazzi wants to merge 1 commit into
NousResearch:mainfrom
iborazzi:fix/qqbot-connect-is-reconnect-param

Conversation

@iborazzi

@iborazzi iborazzi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Closes #52914

Supersedes #52922, which was closed due to encoding artifacts in the diff
(BOM + mojibake introduced by a local editor/PowerShell re-encoding pass —
see OutThisLife's comment on #52922). This PR is a clean rebase onto
current upstream/main; the diff is exactly the one-line signature change
below, no unrelated formatting or encoding changes.

is_reconnect was added to BasePlatformAdapter.connect() in commit
43b8ba4 (fix(telegram): preserve Bot API update queue on watcher
reconnect). QQAdapter was never updated to accept it, so the gateway's
reconnect watcher raises TypeError: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect' on every reconnect attempt,
causing an infinite retry loop (see #52914 for full repro + logs).

The flag is accepted and intentionally ignored — QQ has no server-side
update queue to preserve, unlike Telegram.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery platform/qqbot QQ Bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists labels Jul 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #52966 — identical one-line signature fix (async def connect(self, *, is_reconnect: bool = False)) for the QQBot reconnect TypeError (issue #52914). The predecessor #52922 you supersede is closed/unmerged, so the canonical fix is the earliest still-open PR #52966. Related: #52914 (the issue), #52922 (closed prior attempt).

@iborazzi

iborazzi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Understood — happy to defer to #52966 as the canonical fix. Leaving this
open in case it's useful as a reference (clean rebase onto current
upstream/main, all 23 checks green, no conflicts) but no objection to
closing as duplicate.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the clean duplicate and for explicitly deferring to the canonical fix.

Automated hermes-sweeper review found that this exact behavior is already on current main:

Closing as implemented on main.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/qqbot QQ Bot adapter sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: fix(qqbot): QQBot adapter.connect() missing is_reconnect parameter causes infinite retry loop

3 participants