fix(qqbot): accept is_reconnect kwarg in connect() to match base adapter interface - #57537
fix(qqbot): accept is_reconnect kwarg in connect() to match base adapter interface#57537iborazzi wants to merge 1 commit into
Conversation
Duplicate of #52966 — identical one-line signature fix ( |
|
Understood — happy to defer to #52966 as the canonical fix. Leaving this |
|
Thanks for the clean duplicate and for explicitly deferring to the canonical fix. Automated hermes-sweeper review found that this exact behavior is already on current
Closing as implemented on main. |
Closes #52914
Supersedes #52922, which was closed due to encoding artifacts in the diff
(BOM + mojibake introduced by a local editor/PowerShell re-encoding pass —
see OutThisLife's comment on #52922). This PR is a clean rebase onto
current upstream/main; the diff is exactly the one-line signature change
below, no unrelated formatting or encoding changes.
is_reconnectwas added toBasePlatformAdapter.connect()in commit43b8ba4 (fix(telegram): preserve Bot API update queue on watcher
reconnect). QQAdapter was never updated to accept it, so the gateway's
reconnect watcher raises
TypeError: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'on every reconnect attempt,causing an infinite retry loop (see #52914 for full repro + logs).
The flag is accepted and intentionally ignored — QQ has no server-side
update queue to preserve, unlike Telegram.