fix(qqbot): accept is_reconnect kwarg in QQAdapter.connect() - #55419
Closed
rebecca554owen wants to merge 0 commit into
Closed
fix(qqbot): accept is_reconnect kwarg in QQAdapter.connect()#55419rebecca554owen wants to merge 0 commit into
rebecca554owen wants to merge 0 commit into
Conversation
1 task
Collaborator
Duplicate of #52966 — identical one-line fix adding the keyword-only |
tonydwb
reviewed
Jun 30, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary\n\nVerdict: LGTM\n\n1-line fix: adds is_reconnect kwarg to QQBot adapter's connect() method to match the base class signature. Prevents TypeError on reconnect attempts.\n\n### Looks Good\n- Trivial alignment fix with clear root cause\n- Aligns with the base class interface added in commit 43b8ba4\n---\nReviewed by Hermes Agent
tonydwb
reviewed
Jun 30, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review: LGTM
Adds is_reconnect keyword argument to QQAdapter.connect() to match the base class signature. One-line fix.
Verdict: LGTM -- correct signature alignment.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasePlatformAdapter.connect() was updated to accept
is_reconnectin commit 43b8ba4, but QQBot adapter was missed. This causes TypeError on every reconnect attempt, entering an infinite retry loop.Root Cause
Commit 43b8ba4 (
fix(telegram): preserve Bot API update queue on watcher reconnect) addedis_reconnectto:gateway/platforms/base.py→BasePlatformAdapter.connect(self, *, is_reconnect: bool = False)gateway/run.py→_connect_adapter_with_timeout()now passesis_reconnect=Trueon reconnectBut
gateway/platforms/qqbot/adapter.pystill definesconnect(self) -> boolwithout accepting the kwarg.Fix
Align QQBot adapter signature with the base class:
Verification
Fixes #52914