python3Packages.qiskit: 0.14.0 -> 0.17.0

[drewrisinger]

Motivation for this change

pythonPackages.qiskit build was broken because upstream refactored the package into several smaller packages.

This PR fully refactors the Qiskit library into the subpackages, which are all tested as much as possible, and includes new dependency packages as necessary (or updates to existing packages).

Things done

My apologies, I know this is a pretty big PR to review. Every new dependency added was necessary for build & tests to pass, minus stestr which is primarily for faster testing.

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". No diff detected
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Note: most of these packages are missing maintainers. I'm not sure how that process works, and will update when told.

[drewrisinger]

The failing check seems to be related to removing obsolete IBMQuantumExperience package.

[jonringer]

If you want to split this into many PRs, that would probably be a good idea

[jonringer]

If you want to split this into many PRs, that would probably be a good idea

[drewrisinger]

If you want to split this into many PRs, that would probably be a good idea

I can do that. We're just looking at ~20 PRs, which is a pain to submit. Any tips on resolving dependency issues b/c the later PRs won't build w/o the previous PRs being approved?

[jonringer]

honestly, a package for each PR isn't a terrible idea: limits scope, makes edits easy, faster to review

[drewrisinger]

Splitting into multiple PRs, one per package. Most issues addressed. My apologies in advance for the deluge of PRs @jonringer

[drewrisinger]

@GrahamcOfBorg eval

[drewrisinger]

@GrahamcOfBorg build python37Packages.qiskit-aqua
@GrahamcOfBorg build python38Packages.qiskit-aqua
@GrahamcOfBorg build python37Packages.qiskit
@GrahamcOfBorg build python38Packages.qiskit

[jonringer]

otherwise LGTM

[drewrisinger]

Ok. Apologies. Built locally with nixpkgs-review pr 78772.
@GrahamcOfBorg eval
Updated in this PR:
@GrahamcOfBorg build python37Packages.qiskit python37Packages.qiskit-ibmq-provider
Added in this PR:
@GrahamcOfBorg build python37Packages.ipyvue python38Packages.ipyvue python37Packages.ipyvuetify python38Packages.ipyvuetify
Dependent of qiskit (enabled now that not broken):
@GrahamcOfBorg build python37Packages.qasm2image

[jonringer]

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/78772
9 package built:
python37Packages.ipyvue python37Packages.ipyvuetify python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python38Packages.ipyvue python38Packages.ipyvuetify python38Packages.qiskit-aqua

[jonringer]

it only took two months, but we did it :)

[drewrisinger]

Yeah, I know. My apologies about the long journey and many messages. Thanks for your help!

…

On Tue, Apr 7, 2020, 9:41 PM Jon ***@***.***> wrote: it only took two months, but we did it :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#78772 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNZYI2ZSXUE6H66NNE3HSTRLPI5LANCNFSM4KNFNTDQ> .