Skip to content

pythonPackages.fastdtw: init at 0.3.4#78868

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-fastdtw
Feb 25, 2020
Merged

pythonPackages.fastdtw: init at 0.3.4#78868
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-fastdtw

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit-terra package #78772 @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger changed the title Dr pr python fastdtw pythonPackages.fastdtw: init at 0.3.4 Jan 30, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

Tried running tests w/ GitHub checkout & pytest, but it has trouble finding the cython-ized code.

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build pythonPackages.fastdtw

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
jonringer
jonringer reviewed Jan 30, 2020
View reviewed changes
jonringer
jonringer reviewed Feb 3, 2020
View reviewed changes
@drewrisinger drewrisinger mentioned this pull request Feb 24, 2020
Open
@drewrisinger drewrisinger force-pushed the dr-pr-python-fastdtw branch 2 times, most recently from 80fe458 to bccaf47 Compare February 24, 2020 15:50
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 24, 2020

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 24, 2020

@GrahamcOfBorg eval

@drewrisinger
pythonPackages.fastdtw: init at 0.3.4
de02a7f 
Fast implementation of Dynamic Time Warping algorithm.

Dependency for qiskit-aqua.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 24, 2020

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw
@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

jonringer commented Feb 25, 2020

@GrahamcOfBorg build python37Packages.fastdtw python38Packages.fastdtw

@drewrisinger drewrisinger deleted the dr-pr-python-fastdtw branch February 25, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewrisinger @jonringer