Skip to content

libcint: init at 3.0.19#78871

Merged
timokau merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-libcint
Feb 3, 2020
Merged

libcint: init at 3.0.19#78871
timokau merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-libcint

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit-terra package #78772

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
@drewrisinger drewrisinger mentioned this pull request Jan 30, 2020
Closed
10 tasks
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build libcint

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jan 30, 2020
@drewrisinger drewrisinger requested a review from timokau February 3, 2020 18:40
timokau
timokau requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit name libraries.libcint suggests that libcint is part of the libraries package set (i.e. that you can nix build libraries.libcint. The commit should just be libcint: init....

A rebase on latest master would be nice, since the maintainer commit is already merged.

@drewrisinger drewrisinger force-pushed the dr-pr-libcint branch 2 times, most recently from 8ed31b4 to ecc2922 Compare February 3, 2020 21:59
@drewrisinger
libcint: init at 3.0.19
3e5789a 
C library of general GTO integrals for quantum chemistry.

Requirement for pyscf, which is a requirement for qiskit-aqua.
@drewrisinger drewrisinger changed the title libraries.libcint: init at 3.0.19 libcint: init at 3.0.19 Feb 3, 2020
@drewrisinger drewrisinger requested a review from timokau February 3, 2020 22:12
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 3, 2020

@timokau thanks for your review/comments. Much appreciated. All changes made, and notes made on python2 requirement.

@timokau
Copy link
Member

timokau commented Feb 3, 2020

Looks perfect, thanks!

@timokau timokau merged commit c636a45 into NixOS:master Feb 3, 2020
@drewrisinger drewrisinger deleted the dr-pr-libcint branch February 24, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timokau timokau timokau approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewrisinger @timokau