Skip to content

pythonPackages.ecos: init at 2.0.7.post1#78882

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-ecos
Feb 19, 2020
Merged

pythonPackages.ecos: init at 2.0.7.post1#78882
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-ecos

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit package #78772
Split from #78772 per request

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jan 30, 2020
View reviewed changes
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 3, 2020

Depends on #79187

@ofborg ofborg bot requested a review from bhipple February 3, 2020 23:47
@jonringer
Copy link
Contributor

jonringer commented Feb 17, 2020

please address conflicts

@drewrisinger
pythonPackages.ecos: init at 2.0.7.post1
36cea1c 
Embedded cone solver interface for optimization problems in Python.
Dependency of qiskit-ignis.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

conflicts should be resolved.

jonringer
jonringer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
has tests 👍

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78882
2 package built:
python37Packages.ecos python38Packages.ecos

@jonringer
Copy link
Contributor

jonringer commented Feb 19, 2020

@GrahamcOfBorg build python37Packages.ecos python38Packages.ecos

@drewrisinger drewrisinger deleted the dr-pr-python-ecos branch February 20, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@bhipple bhipple Awaiting requested review from bhipple

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewrisinger @jonringer