Skip to content

pythonPackages.docloud: init at 1.0.375#78874

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-docloud
Feb 17, 2020
Merged

pythonPackages.docloud: init at 1.0.375#78874
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-docloud

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add sub-dependency for upcoming package qiskit-aqua #78772 @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
The IBM Decision Optimization on Cloud Python client.

Requirement of docplex, which is a dependency of qiskit-aqua.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not going to lie, this package is "smelly":

  • versioning looks like incremental releases
  • no tests

I guess the dependency list is small and stable. But I'm not really convinced this belongs in nixpkgs.

Looking at the example for qiskit (which is the end goal), it's meant to be consumed as an sdk, which means it will have to play well with the rest of t he python-ecosystem.

My main concern is that the nixpkgs python ecosystem (which has a pretty fast and steady cadence), may make this really fragile (E.g, one of the new 27 dependencies is broken, now it's broken too).

If you're willing to be active and maintain these package set I'll be cooperative in getting it in, but generally it's the case that the core contributors take the lion share of having to maintain these packages.

For example, the google package set right now has namespace issues so it's horribly broken at the moment. But I don't have the time or cares to fix it, and the original maintainer is longer able to be found.

@drewrisinger
Copy link
Contributor Author

Fair. Thanks for your help with this whole process. It looks like the qiskit-aqua package will be broken then without the qiskit-aqua -> docplex -> docloud dependency, as the docplex dependency is pretty deep, e.g. covered in the README. ising/docplex.py and test_readme_sample.py.

If I can't get the entire qiskit package approved, I still propose approving AT LEAST the qiskit-terra and potentially the qiskit-aer package, which have fewer exotic dependencies. I can break those into separate PRs if so.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM (would still like tests)
trusting @drewrisinger to help maintain these packages :)

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78874
3 package built:
python27Packages.docloud python37Packages.docloud python38Packages.docloud

@drewrisinger drewrisinger deleted the dr-pr-python-docloud branch February 18, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants