Skip to content

lib.science.math.scs: 2.0.2 -> 2.1.1#78896

Merged
mmahut merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-lib-scs
Jan 31, 2020
Merged

lib.science.math.scs: 2.0.2 -> 2.1.1#78896
mmahut merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-lib-scs

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit #78772

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger requested a review from bhipple January 30, 2020 18:37
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build scs

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
jonringer
jonringer approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[3 built, 2 copied (21.6 MiB), 2.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78896
1 package built:
scs

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 31, 2020

Done & force-pushed. Please merge @jonringer
@GrahamcOfBorg build scs

@ofborg ofborg bot requested a review from bhipple January 31, 2020 21:48
@mmahut mmahut merged commit 7b46677 into NixOS:master Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@mmahut @anna328p
Merge pull request NixOS#78896 from drewrisinger/dr-pr-lib-scs
c5d6500 
lib.science.math.scs: 2.0.2 -> 2.1.1
@drewrisinger drewrisinger deleted the dr-pr-lib-scs branch February 3, 2020 15:33
@drewrisinger drewrisinger mentioned this pull request Feb 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhipple bhipple Awaiting requested review from bhipple

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drewrisinger @bhipple @jonringer @mmahut