Skip to content

pythonPackages.subunit: enable tests#78877

Closed
drewrisinger wants to merge 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-subunit-tests
Closed

pythonPackages.subunit: enable tests#78877
drewrisinger wants to merge 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-subunit-tests

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Enable & run tests built into the subunit package.
Subunit is dependency for stestr, test package used in qiskit (#78772 ) @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger mentioned this pull request Jan 30, 2020
Closed
10 tasks
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 30, 2020
FRidh
FRidh reviewed Feb 9, 2020
View reviewed changes
@drewrisinger drewrisinger force-pushed the dr-pr-python-subunit-tests branch from a7bdb59 to 22a4791 Compare February 11, 2020 15:15
@drewrisinger
pythonPackages.subunit: enable tests
c39e4cb 
Enable & run tests built into the subunit package.
@drewrisinger drewrisinger force-pushed the dr-pr-python-subunit-tests branch from 22a4791 to c39e4cb Compare February 11, 2020 15:17
jonringer
jonringer suggested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding this commit to #78876 , as that change to the subunit package breaks these packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drewrisinger @FRidh @jonringer