Skip to content

pythonPackages.marshmallow-polyfield: init at 5.7#78867

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-marshmallow-polyfield
Feb 12, 2020
Merged

pythonPackages.marshmallow-polyfield: init at 5.7#78867
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-marshmallow-polyfield

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit-terra package #78772 @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build python3Packages.marshmallow-polyfield

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
@drewrisinger
pythonPackages.marshmallow-polyfield: init at 5.7
c7071b0 
This python package allows polymorphic data fields in marshmallow
serialization/deserialization schema.

This is a requirement for qiskit.
@drewrisinger drewrisinger force-pushed the dr-pr-python-marshmallow-polyfield branch from 9a8065e to c7071b0 Compare February 3, 2020 22:54
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

@GrahamcOfBorg build python3Packages.marshmallow-polyfield

jonringer
jonringer approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78867
2 package built:
python37Packages.marshmallow-polyfield python38Packages.marshmallow-polyfield

@drewrisinger drewrisinger deleted the dr-pr-python-marshmallow-polyfield branch February 18, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drewrisinger @FRidh @jonringer