Skip to content

pythonPackages.docplex: init at 2.12.182#78875

Merged
FRidh merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-docplex
Feb 19, 2020
Merged

pythonPackages.docplex: init at 2.12.182#78875
FRidh merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-docplex

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming package qiskit-aqua #78772 @jonringer
Depends on #78874

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation labels Jan 30, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build python3Packages.docplex

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 30, 2020

build fails b/c missing docloud. PR #78874 must be approved first

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

Should work now that #78874 has been approved. Builds locally.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 18, 2020
jonringer
jonringer reviewed Feb 18, 2020
View reviewed changes
@jonringer
Copy link
Contributor

jonringer commented Feb 18, 2020

otherwise LGTM

[5 built, 3 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78875
3 package built:
python27Packages.docplex python37Packages.docplex python38Packages.docplex

@drewrisinger drewrisinger mentioned this pull request Feb 18, 2020
Merged
10 tasks
@drewrisinger
pythonPackages.docplex: init at 2.12.182
cc4cc72 
The IBM Decision Optimization CPLEX Modeling for Python.

Dependency of qiskit-aqua.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

@GrahamcOfBorg build python37Packages.docplex python38Packages.docplex

@FRidh FRidh merged commit ee65cd9 into NixOS:master Feb 19, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-docplex branch February 20, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drewrisinger @jonringer @FRidh