pythonPackages.pylatexenc: init at 2.1#78878
Merged
jonringer merged 1 commit intoNixOS:masterfrom Feb 19, 2020
Merged
Conversation
Contributor
Author
|
@GrahamcOfBorg build python3Packages.pylatexenc |
ofborg
bot
added
6.topic: python
drewrisinger
force-pushed
the
dr-pr-python-pylatexenc
branch
from
4c57657 to
4e9dc14
Compare
Contributor
Author
|
@GrahamcOfBorg build python3Packages.pylatexenc |
ofborg
bot
added
the
11.by: package-maintainer
Latex converter for Python. Check dependency of qiskit.
drewrisinger
force-pushed
the
dr-pr-python-pylatexenc
branch
from
4e9dc14 to
6ee5dea
Compare
10 tasks
Contributor
Author
|
@jonringer This is a simple PR, fully tested. No smells like the #78874 #78875 (docloud/docplex) ones. This is the only remaining dependency for #80464, which is similarly fully tested and should be mergeable. |
Contributor
Author
|
@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc |
jonringer
approved these changes
Feb 19, 2020
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
diff LGTM
commit LGTM
has tests 👍
[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78878
3 package built:
python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc
Contributor
|
@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add dependency for upcoming qiskit package #78772 @jonringer
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)