Skip to content

pythonPackages.osqp: init at 0.6.1#78883

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-osqp
Feb 19, 2020
Merged

pythonPackages.osqp: init at 0.6.1#78883
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-osqp

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit package #78772

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger changed the title Dr pr python osqp pythonPackages.osqp: init at 0.6.1 Jan 30, 2020
jonringer
jonringer reviewed Jan 30, 2020
View reviewed changes
pkgs/development/python-modules/osqp/default.nix Outdated
Copy link
Contributor

@jonringer jonringer Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is mkl needed at runtime? or just part of the tests?

Copy link
Contributor Author

@drewrisinger drewrisinger Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, MKL is an optional runtime dependency. https://github.com/oxfordcontrol/osqp/blob/d7eeb245d5b7f0195bfc35b6cb71f4570d7ca18b/docs/get_started/linear_system_solvers.rst

It comes with a system solver built in, but if MKL is available it uses it for faster/larger problems.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2020
jonringer
jonringer approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
upstream seems active
has tests 👍

[7 built, 2 copied (3.5 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78883
3 package built:
python27Packages.osqp python37Packages.osqp python38Packages.osqp

@jonringer
Copy link
Contributor

jonringer commented Feb 14, 2020

@GrahamcOfBorg build python27Packages.osqp python37Packages.osqp python38Packages.osqp

@jonringer
Copy link
Contributor

jonringer commented Feb 14, 2020

ping me if I don't get back to this in a day or 2

@drewrisinger drewrisinger mentioned this pull request Feb 18, 2020
Merged
10 tasks
@drewrisinger
pythonPackages.osqp: init at 0.6.1
1fe4c09 
Oxford Splitting QP solver.
Dependency for cvxpy -> qiskit-aer.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

@jonringer ping. Rebased on master, double-checked build on local.
@GrahamcOfBorg eval

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

@GrahamcOfBorg build python27Packages.osqp python37Packages.osqp python38Packages.osqp

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Feb 18, 2020

bot build fails b/c requires non-free mkl for tests. Thoughts?

@jonringer
Copy link
Contributor

jonringer commented Feb 19, 2020

fine, passes on my machine

@jonringer
Copy link
Contributor

jonringer commented Feb 19, 2020 

https://github.com/NixOS/nixpkgs/pull/78883
3 package built:
python27Packages.osqp python37Packages.osqp python38Packages.osqp

@drewrisinger drewrisinger deleted the dr-pr-python-osqp branch February 20, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewrisinger @jonringer