pythonPackages.cvxpy: init at 1.0.25#78898
Merged
jonringer merged 1 commit intoNixOS:masterfrom Feb 22, 2020
Merged
Conversation
ofborg
bot
added
the
6.topic: python
Contributor
|
please fix eval |
drewrisinger
force-pushed
the
dr-pr-python-cvxpy
branch
from
201e84c to
2a04f85
Compare
Contributor
Author
|
@GrahamcOfBorg eval |
jonringer
reviewed
Feb 18, 2020
Contributor
There was a problem hiding this comment.
looks like osqp doesn't exist yet
python-modules/cvxpy/default.nix:1:1 called without required argument 'osqp'
Member
|
please rebase |
Contributor
Author
|
Rebased, but still waiting on #78897 |
drewrisinger
force-pushed
the
dr-pr-python-cvxpy
branch
from
2a04f85 to
56d46c1
Compare
Contributor
|
merged, sorry about that |
Contributor
|
@GrahamcOfBorg eval |
jonringer
reviewed
Feb 20, 2020
ofborg
bot
added
8.has: package (new)
Convex optimization problem modeler in Python. Dependency of qiskit-aer.
drewrisinger
force-pushed
the
dr-pr-python-cvxpy
branch
from
56d46c1 to
261b30a
Compare
Contributor
Author
|
@GrahamcOfBorg build python37Packages.cvxpy python38Packages.cvxpy |
Contributor
Author
|
bot builds fail b/c scs package uses mkl (non-free). |
This was referenced Feb 20, 2020
jonringer
approved these changes
Feb 22, 2020
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
diff LGTM
commit LGTM
has tests 👍
[9 built, 19 copied (65.8 MiB), 12.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78898
2 package built:
python37Packages.cvxpy python38Packages.cvxpy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add dependency for upcoming qiskit package #78772 @jonringer
Depends on #78897
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)