Skip to content

Update OCEAN_BASIN_FILE_ORION for marine ctest (#1568)#1569

Merged
RussTreadon-NOAA merged 2 commits into
developfrom
feature/msu_path
Mar 25, 2025
Merged

Update OCEAN_BASIN_FILE_ORION for marine ctest (#1568)#1569
RussTreadon-NOAA merged 2 commits into
developfrom
feature/msu_path

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Mar 24, 2025

Description

Update the path to OCEAN_BASIN_FILE_ORION in marine ctests. This change brings GDASApp into consistency with the change merged into g-w develop via PR #3488

Companion PRs

Required by g-w PR #3488

Issues

Resolves #1568

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Warning

While the change in this PR is minor, it may take a while to get either C48mx500_3DVarAOWCDA or C48mx500_hybAOWCDA to successfully run on Orion or Hercules. Both machines are seeing jobs fail due to their running longer than usual, exceeding the specified job wall clock limit, and being terminated by the system.

Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated path is correct, thanks @RussTreadon-NOAA !

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Hercules ctests

Install g-w develop at 63ed862ed. Install feature/msu_path at 794355c in sorc/gdas.cd.

Run test_gdasapp_C48mx500_3DVarAOWCDA with the following results

Test project /work/noaa/da/rtreadon/git/global-workflow/check/sorc/gdas.cd/build
      Start 2065: test_gdasapp_C48mx500_3DVarAOWCDA
 1/10 Test #2065: test_gdasapp_C48mx500_3DVarAOWCDA ....................................   Passed    9.22 sec
      Start 2066: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_stage_ic_202103241800
 2/10 Test #2066: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_stage_ic_202103241800 .........   Passed   50.17 sec
      Start 2067: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_waveinit_202103241800
 3/10 Test #2067: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_waveinit_202103241800 .........   Passed  212.29 sec
      Start 2068: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_fcst_202103241800
 4/10 Test #2068: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_fcst_202103241800 .............   Passed  629.96 sec
      Start 2069: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_prepoceanobs_202103250000
 5/10 Test #2069: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_prepoceanobs_202103250000 .....   Passed  385.71 sec
      Start 2070: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marinebmat_202103250000
 6/10 Test #2070: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marinebmat_202103250000 .......   Passed  165.01 sec
      Start 2071: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlinit_202103250000
 7/10 Test #2071: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlinit_202103250000 ....   Passed  188.26 sec
      Start 2072: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlvar_202103250000
 8/10 Test #2072: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlvar_202103250000 .....   Passed  118.71 sec
      Start 2073: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlchkpt_202103250000
 9/10 Test #2073: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlchkpt_202103250000 ...   Passed  397.41 sec
      Start 2074: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlfinal_202103250000
10/10 Test #2074: test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlfinal_202103250000 ...   Passed  281.25 sec

100% tests passed, 0 tests failed out of 10

Label Time Summary:
gdasapp    = 2437.99 sec*proc (10 tests)
script     = 2437.99 sec*proc (10 tests)

Total Test time (real) = 2438.32 sec

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Hercules ctests, part 2

Run test_gdasapp_C48mx500_hybAOWCDA with the following results


Test project /work/noaa/da/rtreadon/git/global-workflow/check/sorc/gdas.cd/build
      Start 2075: test_gdasapp_C48mx500_hybAOWCDA
 1/13 Test #2075: test_gdasapp_C48mx500_hybAOWCDA ....................................   Passed    9.95 sec
      Start 2076: test_gdasapp_C48mx500_hybAOWCDA_gdas_stage_ic_202103241800
 2/13 Test #2076: test_gdasapp_C48mx500_hybAOWCDA_gdas_stage_ic_202103241800 .........   Passed   25.65 sec
      Start 2077: test_gdasapp_C48mx500_hybAOWCDA_gdas_fcst_202103241800
 3/13 Test #2077: test_gdasapp_C48mx500_hybAOWCDA_gdas_fcst_202103241800 .............   Passed  533.41 sec
      Start 2078: test_gdasapp_C48mx500_hybAOWCDA_enkfgdas_stage_ic_202103241800
 4/13 Test #2078: test_gdasapp_C48mx500_hybAOWCDA_enkfgdas_stage_ic_202103241800 .....   Passed   41.01 sec
      Start 2079: test_gdasapp_C48mx500_hybAOWCDA_enkfgdas_fcst_202103241800
 5/13 Test #2079: test_gdasapp_C48mx500_hybAOWCDA_enkfgdas_fcst_202103241800 .........   Passed  410.82 sec
      Start 2080: test_gdasapp_C48mx500_hybAOWCDA_gdas_prepoceanobs_202103250000
 6/13 Test #2080: test_gdasapp_C48mx500_hybAOWCDA_gdas_prepoceanobs_202103250000 .....   Passed  273.55 sec
      Start 2081: test_gdasapp_C48mx500_hybAOWCDA_gdas_marinebmat_202103250000
 7/13 Test #2081: test_gdasapp_C48mx500_hybAOWCDA_gdas_marinebmat_202103250000 .......   Passed  172.32 sec
      Start 2082: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlletkf_202103250000
 8/13 Test #2082: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlletkf_202103250000 ...   Passed  130.50 sec
      Start 2083: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlinit_202103250000
 9/13 Test #2083: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlinit_202103250000 ....   Passed  342.91 sec
      Start 2084: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000
10/13 Test #2084: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000 .....   Passed  194.45 sec
      Start 2085: test_gdasapp_C48mx500_hybAOWCDA_gdas_ocnanalecen_202103250000
11/13 Test #2085: test_gdasapp_C48mx500_hybAOWCDA_gdas_ocnanalecen_202103250000 ......   Passed   47.41 sec
      Start 2086: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000
12/13 Test #2086: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 ...   Passed   52.46 sec
      Start 2087: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000
13/13 Test #2087: test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 ...   Passed  115.57 sec

100% tests passed, 0 tests failed out of 13

Label Time Summary:
gdasapp    = 2350.03 sec*proc (13 tests)
script     = 2350.03 sec*proc (13 tests)

Total Test time (real) = 2352.39 sec

@RussTreadon-NOAA RussTreadon-NOAA added the orion-GW-RT Queue for automated testing with global-workflow on Orion label Mar 24, 2025
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 24, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 24, 2025

Automated GW-GDASApp Testing Results:
Machine: orion

Start: Mon Mar 24 01:54:03 PM CDT 2025 on orion-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Mar 24 02:52:13 PM CDT 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Mon Mar 24 03:14:23 PM CDT 2025
Tests: 100% tests passed, 0 tests failed out of 56

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Mar 24, 2025
Copy link
Copy Markdown
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path changes look good. Thanks!

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @KateFriedman-NOAA and @DavidHuber-NOAA for your reviews and approvals. Merging now.

@RussTreadon-NOAA RussTreadon-NOAA merged commit eb73ac2 into develop Mar 25, 2025
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/msu_path branch March 25, 2025 11:33
@guillaumevernieres
Copy link
Copy Markdown
Contributor

Thanks @RussTreadon-NOAA !

danholdaway added a commit that referenced this pull request Mar 26, 2025
* develop:
  added original date (#1570)
  Update OCEAN_BASIN_FILE_ORION path for marine ctest (#1569)
  Fixing window_begin and end in yaml for redating ADT (#1565)
  Save LETKF mean analysis and mean increment for verification (#1566)
  Update JEDI hashes (20250324) (#1567)
  Removes obsolete json files from marine bufr2ioda (#1564)
  Add hybrid 4denvar as a phase3 validation configuration (#1552)
  Bugfix/ocn ecen (#1550)
  Bugfix SSS obs for LETKF (#1560)
  Bugfix ocean ensemble recentering (#1558)
  apply ci path patch only when running g-w ctests (#1554)
  Update JEDI hashes (20250317)  (#1531)
  add option to create_experiment.py in create_exp.sh  (#1546)
  Update jcb hashes and support initial IODA stats capability (#1547)
  Fix GW-CI CTest dependencies (#1534)
  Converts prepoceanobs to use JCB-style obs list and config files (#1527)
  JEDI-based ensemble recentering and analysis calculation (#1488)
  tools for phase3 validation (#1526)
  Update JEDI hashes (20250306) (#1520)
  New jcb-gdas # and insitu obs prep bug fix  (#1523)
  Marine in situ obs update (SSS, moorings, drifters) (#1511)
  Save marine background and analysis spread (#1517)
  Minor build and install updates and ctest cleanup (#1512)
  correct logic for upper loop limit in chem_diagb (#1516)
  Incorporate multi-cycle concatination and separation of variables in post-BUFR observations (#1504)
  Update JEDI hashes (20250225) (#1475)
  Add a depth dependent e-fold scale (#1494)
  Update jcb and da-utils hashes to support land DA. (#1509)
  Add options to inflate the ensemble while recentering (#1501)
  Add components to use jcb yamls for marine letkf job (#1486)
  Add GNSSRO bufr2ioda and json files (#1448)
  Removal of the marine verification tools (#1499)
  update logic to identify MSU machine (#1498)
  IODA Converter with In-Situ Observations Concatenation and ObsError Inflation (#1472)
  Add sea ice recentering (#1478)
  marine vrfy bugfix (#1483)
  add LD_LIBRARY_PATH patch for wcoss2 build (#1484)
  Bugfix for ensemble recenter + add a test (#1477)
  Add code changes for the implementation of the  low-resolution B (#1441)
  update spack-stack path in Hera modulefiles (#1471)
  fixed glider output filename (#1469)
  add gdas_waveinit to C48mx500_3DVarAOWCDA ctest suite (#1470)
  update jcb-gdas hash 20250128 (#1466)
  Time series of omb stats and html doc (#1463)
  Update marine vrfy HTML codes (#1464)
  Automate the verify tools to submit from start pdy to end pdy (#1458)
  Update an offline marine vrfy tool (#1447)
  Update JEDI hashes (20250127) (#1460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

orion-GW-RT-Passed Automated testing with global-workflow successful on Orion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OCEAN_BASIN_FILE_ORION path

5 participants